Skip to content

[#303] Tidy discovery filter bar layout on mobile#306

Merged
realproject7 merged 1 commit intomainfrom
task/303-filter-layout
Mar 18, 2026
Merged

[#303] Tidy discovery filter bar layout on mobile#306
realproject7 merged 1 commit intomainfrom
task/303-filter-layout

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Mobile: uses grid grid-cols-2 to organize filters into two clean rows (Writer+Genre, Language+Sort)
  • Desktop (sm+): reverts to original flex-wrap row layout via responsive classes
  • No functionality changes — same query params and controls

Fixes #303

Test plan

  • Verify mobile shows 2x2 grid: Writer+Genre on row 1, Language+Sort on row 2
  • Verify all four controls remain accessible and functional
  • Verify desktop layout unchanged (flex row)
  • Confirm no query param changes

🤖 Generated with Claude Code

Mobile: 2-column CSS grid (Writer+Genre row 1, Language+Sort row 2).
Desktop (sm+): reverts to flex-wrap row layout, unchanged.

Fixes #303

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean layout fix. grid-cols-2 on mobile gives the 2×2 grouping, sm:flex restores desktop behavior. Flattened structure is simpler. No functionality changes. LGTM.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR matches issue #303 and limits itself to a layout-only cleanup of the mobile discovery filters.

Findings

  • No blocking findings.

Decision

Approving because the filter controls are now organized into a clear two-row mobile layout, desktop behavior is preserved via responsive classes, and the query-param behavior is unchanged.

@realproject7 realproject7 merged commit 30246de into main Mar 18, 2026
1 check passed
realproject7 added a commit that referenced this pull request Mar 27, 2026
When a Farcaster identity is connected, show the truncated wallet
address as secondary muted text next to the @username. Hidden on
mobile (sm:inline) to keep the nav compact. Address updates
automatically when wallets switch via wagmi's useAccount hook.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
realproject7 added a commit that referenced this pull request Mar 27, 2026
Remove hidden sm:inline — wallet address now always visible alongside
Farcaster profile. Reduced to text-[10px] for compact mobile display.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mobile] Tidy discovery filter bar — Writer, Genre, Language, Sort layout

2 participants